[unitaryhack] Adding a power wrapper for Gates. #27
Conversation
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 94.24% 94.29% +0.04%
==========================================
Files 68 68
Lines 5524 5570 +46
==========================================
+ Hits 5206 5252 +46
Misses 318 318
Continue to review full report at Codecov.
|
| class TestDagger: | ||
| def test_power_of_dagger(self, gate): | ||
| if len(gate.free_symbols) == 0: | ||
| gate.dagger.power(0.5) |
There was a problem hiding this comment.
Maybe I'm missing something, but why is this its own class? We have several tests of dagger above. Maybe we should either put this test up there or take all the dagger tests and put them here?
There was a problem hiding this comment.
I put that test in it's own class as I didn't see a test class dedicated to testing Dagger and wasn't aware that TestMatrixFactoryGate was playing that role. I'm my opinion I think that it would be best to have tests specific to Dagger and MatrixFactoryGate in their own classes respectively. That would allow us to easily find tests specific to a class and also have more certainty that a hypothetical test failure is related to the implementation Dagger rather than that of MatrixFactoryGate.
For the time being, I've removed the TestDagger class and moved the new Dagger test into TestMatrixFactoryGate with the others. If you agree with refactoring those tests in the way I proposed, I think it would be good to apply it in a separate pull request to keep the scope of this one well defined.
|
Thanks for the review @AthenaCaesura! With regards to the formatting, which version of Black are you using? Maybe there are is some custom Black configuration that isn't included in |
|
Thanks, @mstechly! I've updated to Black 22.3 and applied the resulting style updates. |
There was a problem hiding this comment.
Thanks so much for your PR! It will make a really nice addition to our codebase!
Would you like a Zapata T-shirt? If so, then just reply to this thread with an address and size and we'll get it to you.
I will discuss with the person who wrote the tests for dagger about moving them into their own class. 🙂
Happy Hacking!
|
@upsideon maybe instead of providing your address here, just send me an e-mail at michal.stechly@zapatacomputing.com ;) |
5d4c008 Merge pull request #27 from zapatacomputing/ZQS-1112-add-flake8-pyproject ba51d59 add comment for flake8p d300fb8 feat: add flake8-pyproject dependency d8f68df feat: update workflow templates (#26) git-subtree-dir: subtrees/z_quantum_actions git-subtree-split: 5d4c008d19478a3b297fa01bd713e724d0516658
5d4c008 Merge pull request #27 from zapatacomputing/ZQS-1112-add-flake8-pyproject ba51d59 add comment for flake8p d300fb8 feat: add flake8-pyproject dependency d8f68df feat: update workflow templates (#26) git-subtree-dir: subtrees/z_quantum_actions git-subtree-split: 5d4c008d19478a3b297fa01bd713e724d0516658
Description
Fixes orquestra-core/#14 by adding a power wrapper for
Gateinstances. The wrapper allows arbitrary powers of existing gates to be used without having to explicitly define them in code. This adds additional flexibity for those using Orquestra.